linux-kernel - Re: [PATCH 3/4] tools/nolibc: don't define new syscall number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230917025945.GF9646@1wt.eu>
Date:   Sun, 17 Sep 2023 04:59:45 +0200
From:   Willy Tarreau <w@....eu>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Shuah Khan <shuah@...nel.org>, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH 3/4] tools/nolibc: don't define new syscall number

On Thu, Sep 14, 2023 at 06:01:19PM +0200, Thomas Weißschuh wrote:
> All symbols created by nolibc are also visible to user code.
> Syscall constants are expected to come from the kernel headers and
> should not be made up by nolibc.
> 
> Refactor the logic to avoid defining syscall numbers.
> Also the new code is easier to understand.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Yeah that's a good point!

Acked-by: Willy Tarreau <w@....eu>
Willy