linux-kernel - Re: [PATCH v1 1/1] ARM: dts: hpe: BUG: Correct GXP register ranges

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6166b695-25af-54b0-9d30-36c75189b0c5@linaro.org>
Date:   Sun, 17 Sep 2023 10:22:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     charles.kearney@....com, verdun@....com, nick.hawkins@....com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] ARM: dts: hpe: BUG: Correct GXP register ranges

On 15/09/2023 18:54, charles.kearney@....com wrote:
> From: Charles Kearney <charles.kearney@....com>
> 
> Bug fix to correct memory ranges on GXP to include host registers. This
> corrects a issue where the host interrupt controller is not available.

Then you miss Fixes tag. Maybe also Cc-stable tag.

> 
> Signed-off-by: Charles Kearney <charles.kearney@....com>
> ---
>  arch/arm/boot/dts/hpe/hpe-gxp.dtsi | 39 +++++++++++++++---------------
>  1 file changed, 20 insertions(+), 19 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/hpe/hpe-gxp.dtsi b/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> index cf735b3c4f35..18230a4754a6 100644
> --- a/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> +++ b/arch/arm/boot/dts/hpe/hpe-gxp.dtsi
> @@ -1,6 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*
> - * Device Tree file for HPE GXP
> + * Device Tree for HPE

How is this related to bug?

>   */
>  
>  /dts-v1/;
> @@ -52,73 +52,74 @@ L2: cache-controller@...40000 {
>  			cache-level = <2>;
>  		};
>  
> -		ahb@...00000 {
> +		ahb@...00000 {
>  			compatible = "simple-bus";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges = <0x0 0xc0000000 0x30000000>;
>  			dma-ranges;
> +			ranges = <0x0 0x80000000 0x20000000>,
> +			<0x40000000 0xc0000000 0x3fff0000>;

Missing proper alignment.


Best regards,
Krzysztof