linux-kernel - Re: [PATCH 3/4] net: phy: Add GPIO and DT support to NCN26000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba9e7fb4-e19f-454c-9542-cb53b45f6b99@lunn.ch>
Date:   Mon, 18 Sep 2023 18:19:20 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc:     Jay Monkman <jtm@...ingdog.com>, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
        Arndt Schuebel <Arndt.Schuebel@...emi.com>
Subject: Re: [PATCH 3/4] net: phy: Add GPIO and DT support to NCN26000

On Mon, Sep 18, 2023 at 11:40:36AM +0100, Vadim Fedorenko wrote:
> > +static int ncn26000_gpio_request(struct gpio_chip *gc, unsigned int offset)
> > +{
> > +	struct ncn26000_priv *priv = gpiochip_get_data(gc);
> > +
> > +	if (offset > 2)
> > +		return -ENODEV;
> > +
> > +	if (priv->gpiomask & (1 << offset))
> 
> it's better to use BIT(offset) here

Hi Vadim

When replying, please trim the email to just the relevant text.

     Thanks
	Andrew