linux-kernel - Re: [syzbot] [fs?] [mm?] WARNING in page_copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQiUd5FAtPXP3OC8@casper.infradead.org>
Date:   Mon, 18 Sep 2023 19:18:31 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Sidhartha Kumar <sidhartha.kumar@...cle.com>
Cc:     syzbot <syzbot+c225dea486da4d5592bd@...kaller.appspotmail.com>,
        akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        llvm@...ts.linux.dev, mike.kravetz@...cle.com,
        muchun.song@...ux.dev, nathan@...nel.org, ndesaulniers@...gle.com,
        syzkaller-bugs@...glegroups.com, trix@...hat.com
Subject: Re: [syzbot] [fs?] [mm?] WARNING in page_copy_sane

On Mon, Sep 18, 2023 at 01:10:21PM -0500, Sidhartha Kumar wrote:
> @@ -382,8 +382,8 @@ static ssize_t hugetlbfs_read_iter(struct kiocb *iocb, struct iov_iter *to)
>  			/*
>  			 * We have the page, copy it to user space buffer.
>  			 */
> -			copied = copy_page_to_iter(page, offset, want, to);
> -			put_page(page);
> +			copied = copy_page_to_iter(&folio->page, offset, want, to);

copy_folio_to_iter() please.  Yes, I know it's just a wrapper today.

> +			folio_put(folio);
>  		}
>  		offset += copied;
>  		retval += copied;
> -- 
> 2.41.0
>