linux-kernel - Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6e5eff10-949c-4f17-a3f3-347b85b89e11@roeck-us.net>
Date:   Mon, 18 Sep 2023 12:05:19 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas Weißschuh <linux@...ssschuh.net>
Cc:     Jean Delvare <jdelvare@...e.com>, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Douglas Gilbert <dgilbert@...erlog.com>
Subject: Re: [PATCH] hwmon: powerz: add support for ChargerLAB KM002C

On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
> The KM002C is similar to the KM003C and seems to use the same
> protocol and firmware.
> 
> Reported-by: Douglas Gilbert <dgilbert@...erlog.com>
> Closes: https://lore.kernel.org/lkml/290ebce4-54f0-8ac1-2a13-cbc806d80d64@interlog.com/
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
> ---
> 
> This patch is based on hwmon-next,
> commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Applied, but please be more careful with your comments and Signed-off-by:
tags. There should only be one '---', and one signature. 

Thanks,
Guenter

> ---
>  drivers/hwmon/powerz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> 
> ---
> base-commit: 80369d9e1f2f16993ae6d148553c37bf65a209e4
> change-id: 20230911-powerz-km002c-94afb4d3d645
> 
> Best regards,
> 
> diff --git a/drivers/hwmon/powerz.c b/drivers/hwmon/powerz.c
> index 2b9693aee6f6..cfb635f94d66 100644
> --- a/drivers/hwmon/powerz.c
> +++ b/drivers/hwmon/powerz.c
> @@ -254,6 +254,7 @@ static void powerz_disconnect(struct usb_interface *intf)
>  }
>  
>  static const struct usb_device_id powerz_id_table[] = {
> +	{ USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0061, 0x00) },	/* ChargerLAB POWER-Z KM002C */
>  	{ USB_DEVICE_INTERFACE_NUMBER(0x5FC9, 0x0063, 0x00) },	/* ChargerLAB POWER-Z KM003C */
>  	{ }
>  };