[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7412a756ee4c83c62b3dc866b5a351e1bc4afa33.camel@collabora.com>
Date: Mon, 18 Sep 2023 15:16:39 -0400
From: Nicolas Dufresne <nicolas.dufresne@...labora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Sebastian Fricke <sebastian.fricke@...labora.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
Nas Chung <nas.chung@...psnmedia.com>,
Sascha Hauer <s.hauer@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
Jackson Lee <jackson.lee@...psnmedia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
NXP Linux Team <linux-imx@....com>,
Hans Verkuil <hverkuil@...all.nl>,
Conor Dooley <conor+dt@...nel.org>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
Robert Beckett <bob.beckett@...labora.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel@...labora.com
Subject: Re: [PATCH v12 6/7] dt-bindings: media: wave5: add yaml devicetree
bindings
Le lundi 18 septembre 2023 à 14:02 +0200, Krzysztof Kozlowski a écrit :
> On 18/09/2023 08:49, Sebastian Fricke wrote:
> > Hey Krzysztof,
> >
> > thanks for your review.
> >
> > On 17.09.2023 09:56, Krzysztof Kozlowski wrote:
> > > On 15/09/2023 23:11, Sebastian Fricke wrote:
> > > > From: Robert Beckett <bob.beckett@...labora.com>
> > > >
> > > > Add bindings for the wave5 chips&media codec driver
> > > >
> > > > Signed-off-by: Robert Beckett <bob.beckett@...labora.com>
> > > > Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@...labora.com>
> > > > Signed-off-by: Sebastian Fricke <sebastian.fricke@...labora.com>
> > >
> > > So this is v12 and still no tested?
> >
> > I have tested it, multiple times actually since V11. (For some reason
> > that indentation issue slipped by me though ...)
> > If you mean the tested by tag, the patch was completely unnoticed until
> > v10 by the community, which was partially because me and the previous
> > commiters didn't use the right recipients for this patch. So from that
> > point of view this is more like v2.
> >
> > >
> > > A nit, subject: drop second/last, redundant "yaml devicetree indings".
> > > The "dt-bindings" prefix is already stating that these are bindings.
> > > Basically three words bringing zero information.
> >
> > Okay so:
> > `dt-bindings: media: wave5: add devicetree`
>
> Still not, because devicetree is duplicating "dt". It's redundant.
>
> Instead should be (with correct order of prefixes):
>
> media: dt-bindings: wave5: add AzureWaveFooBar XYL ABC10 (whatever
> company and full product name it is)
So maybe this one ?
media: dt-bindings: wave5: add Chips&Media 521c codec IP support
>
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists