[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b7a337f2-a810-d14c-e7cd-15e33a9ecb5d@linaro.org>
Date: Mon, 18 Sep 2023 22:18:37 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Tomer Maimon <tmaimon77@...il.com>, peter.chen@...nel.org,
gregkh@...uxfoundation.org, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, xu.yang_2@....com,
peng.fan@....com, avifishman70@...il.com, tali.perry1@...il.com,
joel@....id.au, venture@...gle.com, yuenn@...gle.com,
benjaminfair@...gle.com, j.neuschaefer@....net
Cc: openbmc@...ts.ozlabs.org, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v1 1/2] dt-binding: usb: ci-hdrc-usb2: document Nuvoton
NPCM supprt
On 18/09/2023 18:59, Tomer Maimon wrote:
> Nuvoton NPCM BMC SoCs use ChipIdea silicon IP for the USB device controller.
>
> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. It's dt-bindings.
> ---
> .../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> index 1394557517b1..9de4dfe004d1 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2.yaml
> @@ -16,6 +16,7 @@ properties:
> - enum:
> - chipidea,usb2
> - lsi,zevio-usb
> + - nuvoton,npcm-udc
You need SoC specific compatible.
> - nvidia,tegra20-ehci
> - nvidia,tegra20-udc
> - nvidia,tegra30-ehci
> @@ -325,6 +326,20 @@ properties:
> type: boolean
> deprecated: true
>
> + nuvoton,sysgcr:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
> + - items:
> + - description: phandle to syscon that configures usb phy mux.
> + - description: offset of usb phy mux selection.
> + - description: mask usb phy mux selection.
> + - description: value usb phy mux selection.
> + description:
> + A phandle to syscon with three arguments that configure usb phy mux.
> + The argument one is the offset of usb phy mux selection, the argument two
> + is the mask usb phy mux selection, the argument three is the mask usb phy
> + mux selection.
Sorry, you miss phy driver. Don't use syscon instead of proper hardware
devices.
Best regards,
Krzysztof
Powered by blists - more mailing lists