[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <64760d6e-10f4-4108-d467-f40289a1c6b4@quicinc.com>
Date: Mon, 18 Sep 2023 13:27:05 -0700
From: Jessica Zhang <quic_jesszhan@...cinc.com>
To: John Watts <contact@...kia.org>, <dri-devel@...ts.freedesktop.org>
CC: Neil Armstrong <neil.armstrong@...aro.org>,
Sam Ravnborg <sam@...nborg.org>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
Shawn Guo <shawnguo@...nel.org>,
Heiko Stuebner <heiko@...ech.de>,
Chris Morgan <macromorgan@...mail.com>,
Jagan Teki <jagan@...eble.ai>,
Paul Cercueil <paul@...pouillou.net>,
Christophe Branchereau <cbranchereau@...il.com>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v2 4/9] drm/panel: nv3052c: Wait before entering sleep
mode
On 9/18/2023 5:58 AM, John Watts wrote:
> The panel needs us to wait 120ms between exiting and entering sleep.
> Guarantee that by always waiting 150ms before entering sleep mode.
Hi John,
Same question as the last patch -- is this a fix for something?
Thanks,
Jessica Zhang
>
> Signed-off-by: John Watts <contact@...kia.org>
> ---
> drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> index 2526b123b1f5..307335d0f1fc 100644
> --- a/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> +++ b/drivers/gpu/drm/panel/panel-newvision-nv3052c.c
> @@ -289,6 +289,9 @@ static int nv3052c_unprepare(struct drm_panel *panel)
> struct mipi_dbi *dbi = &priv->dbi;
> int err;
>
> + /* Wait 150ms in case we just exited sleep mode */
> + msleep(150);
> +
> err = mipi_dbi_command(dbi, MIPI_DCS_ENTER_SLEEP_MODE);
> if (err)
> dev_err(priv->dev, "Unable to enter sleep mode: %d\n", err);
> --
> 2.42.0
>
Powered by blists - more mailing lists