linux-kernel - Re: [PATCH] vfio/pds: Add missing PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230918145111.6473b148.alex.williamson@redhat.com>
Date:   Mon, 18 Sep 2023 14:51:11 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     oushixiong <oushixiong@...inos.cn>
Cc:     Jason Gunthorpe <jgg@...pe.ca>, Yishai Hadas <yishaih@...dia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
        Kevin Tian <kevin.tian@...el.com>,
        Brett Creeley <brett.creeley@....com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vfio/pds: Add missing PCI_IOV depends

On Wed,  6 Sep 2023 09:49:42 +0800
oushixiong <oushixiong@...inos.cn> wrote:

> From: Shixiong Ou <oushixiong@...inos.cn>
> 
> If PCI_ATS isn't set, then pdev->physfn is not defined.
> it causes a compilation issue:
> 
> ../drivers/vfio/pci/pds/vfio_dev.c:165:30: error: ‘struct pci_dev’ has no member named ‘physfn’; did you mean ‘is_physfn’?
>   165 |   __func__, pci_dev_id(pdev->physfn), pci_id, vf_id,
>       |                              ^~~~~~
> 
> So adding PCI_IOV depends to select PCI_ATS.
> 
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
>  drivers/vfio/pci/pds/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to vfio for-linus branch for v6.6.  Thanks,

Alex

> 
> diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig
> index 407b3fd32733..6eceef7b028a 100644
> --- a/drivers/vfio/pci/pds/Kconfig
> +++ b/drivers/vfio/pci/pds/Kconfig
> @@ -3,7 +3,7 @@
>  
>  config PDS_VFIO_PCI
>  	tristate "VFIO support for PDS PCI devices"
> -	depends on PDS_CORE
> +	depends on PDS_CORE && PCI_IOV
>  	select VFIO_PCI_CORE
>  	help
>  	  This provides generic PCI support for PDS devices using the VFIO