linux-kernel - Re: [PATCH AUTOSEL 6.1 20/22] block: Allow bio_iov_iter_get_pages() with bio->bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQi50xT1o/N2o8Bt@sashalap>
Date:   Mon, 18 Sep 2023 16:57:55 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     Pavel Machek <pavel@...x.de>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        Kent Overstreet <kent.overstreet@...ux.dev>,
        linux-block@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 6.1 20/22] block: Allow bio_iov_iter_get_pages()
 with bio->bi_bdev unset

On Mon, Sep 11, 2023 at 07:15:18AM -0600, Jens Axboe wrote:
>On 9/11/23 3:54 AM, Pavel Machek wrote:
>> Hi!
>>
>>> From: Kent Overstreet <kent.overstreet@...ux.dev>
>>>
>>> [ Upstream commit 168145f617d57bf4e474901b7ffa869337a802e6 ]
>>>
>>> bio_iov_iter_get_pages() trims the IO based on the block size of the
>>> block device the IO will be issued to.
>>>
>>> However, bcachefs is a multi device filesystem; when we're creating the
>>> bio we don't yet know which block device the bio will be submitted to -
>>> we have to handle the alignment checks elsewhere.
>>>
>>> Thus this is needed to avoid a null ptr deref.
>>
>> We are certainly not going to backport bcachefs to -stable. Please
>> drop.
>
>I already said as much 3 days ago:
>
>https://lore.kernel.org/all/cd341326-cfaf-4796-8894-2241e7b630d9@kernel.dk/
>
>but didn't hear back yet.

Dropped, and sorry for lack of timely replies on this - I let them
collect feedback for a few weeks before going through it and dropping
what needs to be dropped.

-- 
Thanks,
Sasha