linux-kernel - Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230918211202.GA1743810-robh@kernel.org>
Date:   Mon, 18 Sep 2023 16:12:02 -0500
From:   Rob Herring <robh@...nel.org>
To:     Arınç ÜNAL <arinc.unal@...nc9.com>
Cc:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, mithat.guner@...ont.com,
        erkin.bozoglu@...ont.com, linux-mediatek@...ts.infradead.org,
        linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: pinctrl: mtmips: document pins of groups

On Sun, Sep 17, 2023 at 07:28:37PM +0300, Arınç ÜNAL wrote:
> Document the pins of each group on the MediaTek MTMIPS SoC pin controllers.
> 
> Signed-off-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> ---
>  .../pinctrl/mediatek,mt7620-pinctrl.yaml      | 22 ++++++++++++-
>  .../pinctrl/mediatek,mt7621-pinctrl.yaml      | 18 +++++++++-
>  .../pinctrl/mediatek,mt76x8-pinctrl.yaml      | 33 ++++++++++++++++++-
>  .../pinctrl/ralink,rt2880-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt305x-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt3352-pinctrl.yaml        | 17 +++++++++-
>  .../pinctrl/ralink,rt3883-pinctrl.yaml        | 16 ++++++++-
>  .../pinctrl/ralink,rt5350-pinctrl.yaml        | 13 +++++++-
>  8 files changed, 144 insertions(+), 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> index 221adcef6e14..eb9d9d2bd90f 100644
> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt7620-pinctrl.yaml
> @@ -44,8 +44,28 @@ patternProperties:
>                     wdt refclk, wdt rst, wled]
>  
>            groups:
> -            description:
> +            description: |
>                An array of strings. Each string contains the name of a group.
> +
> +              group             pins
> +              ------------------------------------------------------------------
> +              "i2c"             1, 2
> +              "spi"             3, 4, 5, 6
> +              "uartf"           7, 8, 9, 10, 11, 12, 13, 14
> +              "uartlite"        15, 16
> +              "wdt"             17
> +              "pa"              18, 19, 20, 21
> +              "mdio"            22, 23
> +              "rgmii1"          24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35
> +              "pcie"            36
> +              "spi refclk"      37, 38, 39
> +              "ephy"            40, 41, 42, 43, 44
> +              "nd_sd"           45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56,
> +                                57, 58, 59
> +
> +              "rgmii2"          60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71
> +              "wled"            72

This list of strings should be an enum like 'function' above.

> +
>              maxItems: 1

This is wrong if more than 1 string is allowed...

Same goes for the rest of the changes.

Rob