[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230918213328.GA1771303-robh@kernel.org>
Date: Mon, 18 Sep 2023 16:33:28 -0500
From: Rob Herring <robh@...nel.org>
To: Kwanghoon Son <k.son@...sung.com>
Cc: p.zabel@...gutronix.de, krzysztof.kozlowski+dt@...aro.org,
conor+dt@...nel.org, jszhang@...nel.org, guoren@...nel.org,
wefu@...hat.com, paul.walmsley@...ive.com, palmer@...belt.com,
aou@...s.berkeley.edu, inki.dae@...sung.com,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3 1/3] dt-bindings: reset: Document th1520 reset control
On Mon, Sep 18, 2023 at 04:51:23AM +0000, Kwanghoon Son wrote:
> Add documentation to describe th1520 reset device
>
> Signed-off-by: Kwanghoon Son <k.son@...sung.com>
> ---
> .../bindings/reset/thead,th1520-reset.yaml | 44 +++++++++++++++++++
> .../dt-bindings/reset/thead,th1520-reset.h | 9 ++++
> 2 files changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> create mode 100644 include/dt-bindings/reset/thead,th1520-reset.h
>
> diff --git a/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> new file mode 100644
> index 000000000000..49ea8c6a331f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/thead,th1520-reset.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/thead,th1520-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: T-HEAD th1520 SoC Reset Controller
> +
> +maintainers:
> + - Kwanghoon Son <k.son@...sung.com>
> +
> +properties:
> + compatible:
> + items:
> + - const: thead,th1520-reset
> + - const: syscon
Why do you need "syscon"? Are there other functions? If so, please
describe them in top-level "description". If not, drop "syscon" and use
device_node_to_regmap() instead of syscon_node_to_regmap().
Rob
Powered by blists - more mailing lists