linux-kernel - Re: [PATCH] Input: powermate - fix use-after-free in powermate_config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQjKwQDKmU8L9C9e@google.com>
Date:   Mon, 18 Sep 2023 15:10:09 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Javier Carrasco Cruz <javier.carrasco.cruz@...il.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+0434ac83f907a1dbdd1e@...kaller.appspotmail.com
Subject: Re: [PATCH] Input: powermate - fix use-after-free in
 powermate_config_complete

On Mon, Sep 18, 2023 at 06:51:49AM +0200, Javier Carrasco Cruz wrote:
> Hi,
> 
> There's an obvious error in the patch I introduced when cleaningup
> (urb->status should be used instead of just status). I will send a v2.

I think what we need is call to usb_kill_urb(pm->config) in
powermate_disconnect(), right after call to input_unregister_device().

Thanks.

-- 
Dmitry