linux-kernel - RE: [PATCH] MA-21654 Use dma_alloc_pages in vb2_dma_sg_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR04MB92843816C50A490505170DF187FBA@DB9PR04MB9284.eurprd04.prod.outlook.com>
Date:   Mon, 18 Sep 2023 07:07:13 +0000
From:   Hui Fang <hui.fang@....com>
To:     "tfiga@...omium.org" <tfiga@...omium.org>,
        "m.szyprowski@...sung.com" <m.szyprowski@...sung.com>,
        "mchehab@...nel.org" <mchehab@...nel.org>
CC:     "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Anle Pan <anle.pan@....com>, Xuegang Liu <xuegang.liu@....com>,
        "arakesh@...gle.com" <arakesh@...gle.com>,
        "rdhanjal@...gle.com" <rdhanjal@...gle.com>,
        "jchowdhary@...gle.com" <jchowdhary@...gle.com>
Subject: RE: [PATCH] MA-21654 Use dma_alloc_pages in
 vb2_dma_sg_alloc_compacted

> On Thu, Sep 14, 2023 at 15:52 PM Fang Hui <hui.fang@....com> wrote:
>  ---
> Two things.
> 1. For dma_data_direction para (DMA_BIDIRECTIONAL is used) of
> dma_alloc_pages(),
>   maybe better pass from callers? In DeviceAsWebcam case, it's
> DMA_TO_DEVICE.
> 
> 2. "MA-21654" (NXP ticket number) should be removed in the comment, need
> I re-push or it will be done on your side, thanks!

Another concern is that DMA memory is used up. Maybe first try allocating
low buffer, if failed, fall back to high buffer.

BRs,
Fang Hui