linux-kernel - Re: [PATCH v6 44/45] mm: shrinker: hold write lock to reparent shrinker nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <807B2489-9F74-4B35-925D-B379E47E75AD@linux.dev>
Date:   Mon, 18 Sep 2023 15:17:38 +0800
From:   Muchun Song <muchun.song@...ux.dev>
To:     Qi Zheng <zhengqi.arch@...edance.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, david@...morbit.com,
        tkhai@...ru, Vlastimil Babka <vbabka@...e.cz>,
        Roman Gushchin <roman.gushchin@...ux.dev>, djwong@...nel.org,
        brauner@...nel.org, paulmck@...nel.org, tytso@....edu,
        steven.price@....com, cel@...nel.org, senozhatsky@...omium.org,
        yujie.liu@...el.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v6 44/45] mm: shrinker: hold write lock to reparent
 shrinker nr_deferred



> On Sep 11, 2023, at 17:44, Qi Zheng <zhengqi.arch@...edance.com> wrote:
> 
> For now, reparent_shrinker_deferred() is the only holder of read lock of
> shrinker_rwsem. And it already holds the global cgroup_mutex, so it will
> not be called in parallel.
> 
> Therefore, in order to convert shrinker_rwsem to shrinker_mutex later,
> here we change to hold the write lock of shrinker_rwsem to reparent.
> 
> Signed-off-by: Qi Zheng <zhengqi.arch@...edance.com>

Reviewed-by: Muchun Song <songmuchun@...edance.com>

Thanks.