linux-kernel - RE: [PATCH v2 1/7] pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae5a5665e11242e49b9b84d54b1d4ac3@realtek.com>
Date:   Mon, 18 Sep 2023 03:02:31 +0000
From:   TY_Chang[張子逸] <tychang@...ltek.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 1/7] pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs


Hi Linus,
>
>Hi Tzuyi,
>
>thanks for the new version! This is starting to look really good.
>
>On Thu, Aug 24, 2023 at 12:57 PM Tzuyi Chang <tychang@...ltek.com> wrote:
>
>> The RTD SoCs share a similar design for pinmux and pinconfig.
>> This common pinctrl driver supports different variants within the RTD
>> SoCs.
>>
>> Signed-off-by: Tzuyi Chang <tychang@...ltek.com>
>(...)
>> +static void rtd_pinctrl_update_bits(struct rtd_pinctrl *data, unsigned int offset,
>> +                                   unsigned int mask, unsigned int
>> +val) {
>> +       unsigned int reg = readl_relaxed(data->base + offset);
>> +
>> +       reg &= ~mask;
>> +       reg |= (mask & val);
>> +       writel_relaxed(reg, data->base + offset); }
>
>This function is essentially a reimplementation of regmap_update_bits() using
>regmap_mmio with .user_relaxed_mmio property set in the config.
>
>Have you considered just using regmap-mmio for this?
>

Thank you for the suggestion. I'll use regmap_mmio to replace it in the next version.

>Yours,
>Linus Walleij


Thanks,
Tzuyi Chang