linux-kernel - Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW offloading for KSZ9477

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2023 11:06:18 +0200
From:   Lukasz Majewski <lukma@...x.de>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, Tristram.Ha@...rochip.com,
        Eric Dumazet <edumazet@...gle.com>, davem@...emloft.net,
        Woojung Huh <woojung.huh@...rochip.com>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, UNGLinuxDriver@...rochip.com,
        Oleksij Rempel <linux@...pel-privat.de>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [[RFC PATCH v4 net-next] 0/2] net: dsa: hsr: Enable HSR HW
 offloading for KSZ9477

Hi Vladimir,

> On Thu, Sep 14, 2023 at 11:18:31PM +0200, Lukasz Majewski wrote:
> > As fair as I understood from the commit message - some part of this
> > patch needs to be applied before HSR offloading v4.
> > 
> > Hence I will wait for it to be posted and upstreamed.
> > 
> > Only then some of this patch code would be squashed to v5 of hsr
> > support.  
> 
> No, this isn't how this is going to work. I can't post my patches and
> then you post yours, because that would mean some functionality is
> introduced without a user (ds->ops->port_set_mac_address), and we
> don't accept that, because you may or may not resubmit your HSR
> patches as a first user of the new infra.

Ok. Thanks for the clarification.

> 
> So, what needs to happen is you need to post all the patches as an
> all-or-nothing series. Somewhere in Documentation/process/ it is
> probably explained in more detail what to pay attention to, when
> reposting what is partly others' work. But the basic idea is that you
> need to keep the Author: and Signed-off-by: fields if you aren't
> making major changes, but you must also add your own Signed-off-by:
> at the end. You also have responsibility for the patches that you
> post, and have to respond to review feedback, even if they aren't
> authored for you. You are obviously free to make changes to patches
> until they pass your own criteria.
> 
> The most that I can do to help you is to split that squashed patch and
> put the result on a branch:
> https://github.com/vladimiroltean/linux/commits/lukma-ksz-hsr-rfc-v4
> 
> But it's up to you to take it from there, rebase it on net-next,
> review the result, test it, make sure that the changes are something
> that you can justify when submitting, etc. You won't be alone if you
> need help, of course, but the point is that you're not 100% passive
> to this activity.

No problem. I will test it for a while and then send them for review.

Many thanks for help.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped