linux-kernel - Re: [PATCH] tty: fix memory leak in gsm_activate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2023091850-fever-nintendo-a2b6@gregkh>
Date:   Mon, 18 Sep 2023 11:13:47 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Edward AD <eadavis@...a.com>
Cc:     jirislaby@...nel.org, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org,
        syzbot+b5d1f455d385b2c7da3c@...kaller.appspotmail.com,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] tty: fix memory leak in gsm_activate_mux

On Mon, Sep 18, 2023 at 04:45:26PM +0800, Edward AD wrote:
> On Mon, 18 Sep 2023 10:06:58 +0200, Greg KH wrote:
> > > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > > requested in gsm_dlci_alloc().
> > >
> > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > > Reported-and-tested-by: syzbot+b5d1f455d385b2c7da3c@...kaller.appspotmail.com
> > > Signed-off-by: Edward AD <eadavis@...a.com>
> > > ---
> > >  drivers/tty/n_gsm.c | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > This message never made it to lore.kernel.org, so you might need to fix
> > up your email system so that it doesn't get dropped from there.
> This matter has been bothering me all along. I don't know why, some of the 
> patch emails I sent can be quickly responded to by "lore. kernel. org" correctly, 
> while others cannot. It wasn't until someone like you replied that I could see the 
> patches I sent.
> > 
> > Can you do so and resend?
> Yes, I can.
> However, it may take a long time as I currently do not know how to set up my email 
> system to avoid such issues from occurring.

Look at the tool `patatt`, it's what we use in `b4` to verify emails are
correct and sent by whom they say they are sent by.

Yours fail the checks by that tool, so try sending yourself an email and
work from there.

good luck!

greg k-h