[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2f60de6a-124e-8c8c-1c79-73fa38141e41@microchip.com>
Date: Mon, 18 Sep 2023 11:23:42 +0000
From: <Parthiban.Veerasooran@...rochip.com>
To: <andrew@...n.ch>
CC: <davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
<pabeni@...hat.com>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
<corbet@....net>, <Steen.Hegelund@...rochip.com>,
<rdunlap@...radead.org>, <horms@...nel.org>,
<casper.casan@...il.com>, <netdev@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-doc@...r.kernel.org>, <Horatiu.Vultur@...rochip.com>,
<Woojung.Huh@...rochip.com>, <Nicolas.Ferre@...rochip.com>,
<UNGLinuxDriver@...rochip.com>, <Thorsten.Kummermehr@...rochip.com>
Subject: Re: [RFC PATCH net-next 5/6] microchip: lan865x: add driver support
for Microchip's LAN865X MACPHY
Hi Andrew,
On 14/09/23 7:25 am, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
>> +#define REG_STDR_RESET 0x00000003
>
> This appears to be a standard register, so you should not need to
> define it here.
Ah ok, will do it.
>
>> +#define REG_MAC_ADDR_BO 0x00010022
>> +#define REG_MAC_ADDR_L 0x00010024
>> +#define REG_MAC_ADDR_H 0x00010025
>> +#define REG_MAC_NW_CTRL 0x00010000
>> +#define REG_MAC_NW_CONFIG 0x00010001
>> +#define REG_MAC_HASHL 0x00010020
>> +#define REG_MAC_HASHH 0x00010021
>> +#define REG_MAC_ADDR_BO 0x00010022
>> +#define REG_MAC_ADDR_L 0x00010024
>> +#define REG_MAC_ADDR_H 0x00010025
>> +
>> +#define CCS_Q0_TX_CFG 0x000A0081
>> +#define CCS_Q0_RX_CFG 0x000A0082
>
> These are proprietary vendor registers, so please add a prefix to make
> this clear.
Sure, will add it in the next version.
Best Regards,
Parthiban V
>
> Andrew
Powered by blists - more mailing lists