linux-kernel - Re: [PATCH v2] pinctrl: renesas: pinctrl-rzg2l: Add validation of GPIO pin in rzg2l_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdVcuMGTwNaTY8v-hcbov22zTU268meU28J7+FrWiPioxw@mail.gmail.com>
Date:   Mon, 18 Sep 2023 14:31:20 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Prabhakar <prabhakar.csengg@...il.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Biju Das <biju.das.jz@...renesas.com>,
        Claudiu Beznea <claudiu.beznea.uj@...renesas.com>,
        Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2] pinctrl: renesas: pinctrl-rzg2l: Add validation of
 GPIO pin in rzg2l_gpio_request()

Hi Prabhakar,

On Mon, Sep 11, 2023 at 3:17 PM Prabhakar <prabhakar.csengg@...il.com> wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
>
> Validate the GPIO pin request in rzg2l_gpio_request() callback using
> rzg2l_validate_gpio_pin() function. This stops any accidental usage
> of GPIO pins which are not supported by the SoCs.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> Tested-by: Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
> ---
> v1->v2
> * Maintained reverse christmas tree order.
> * Included RB/TB tags from Claudiu.

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -795,12 +795,18 @@ static const struct pinconf_ops rzg2l_pinctrl_confops = {
>  static int rzg2l_gpio_request(struct gpio_chip *chip, unsigned int offset)
>  {
>         struct rzg2l_pinctrl *pctrl = gpiochip_get_data(chip);
> +       const struct pinctrl_pin_desc *pin = &pctrl->desc.pins[offset];
>         u32 port = RZG2L_PIN_ID_TO_PORT(offset);
>         u8 bit = RZG2L_PIN_ID_TO_PIN(offset);
> +       u64 *pin_data = pin->drv_data;

isn't drv_data a pointer to unsigned int aka u32?

>         unsigned long flags;
>         u8 reg8;
>         int ret;
>
> +       ret = rzg2l_validate_gpio_pin(pctrl, *pin_data, port, bit);
> +       if (ret)
> +               return ret;
> +
>         ret = pinctrl_gpio_request(chip->base + offset);
>         if (ret)
>                 return ret;

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds