[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20230918144708.cntjdjjomj7oy5f5@quack3>
Date: Mon, 18 Sep 2023 16:47:08 +0200
From: Jan Kara <jack@...e.cz>
To: Chunhui He <hchunhui@...l.ustc.edu.cn>
Cc: Theodore Ts'o <tytso@....edu>,
Andreas Dilger <adilger.kernel@...ger.ca>,
linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ext4: trivial: add semicolon after label attributes
On Sat 26-08-23 08:56:58, Chunhui He wrote:
> The gcc document says label attributes are ambiguous if they are
> not immediately followed by a semicolon. Although the ambiguity
> does not arise in C90/99, it would be better to add it.
>
> Link: https://gcc.gnu.org/onlinedocs/gcc/Attribute-Syntax.html#Label-Attributes-2
> Signed-off-by: Chunhui He <hchunhui@...l.ustc.edu.cn>
Fair enough. Feel free to add:
Reviewed-by: Jan Kara <jack@...e.cz>
Honza
> ---
> fs/ext4/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index c94ebf704616..f5fa9815a86e 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5609,7 +5609,7 @@ static int __ext4_fill_super(struct fs_context *fc, struct super_block *sb)
>
> failed_mount10:
> ext4_quotas_off(sb, EXT4_MAXQUOTAS);
> -failed_mount9: __maybe_unused
> +failed_mount9: __maybe_unused;
> ext4_release_orphan_info(sb);
> failed_mount8:
> ext4_unregister_sysfs(sb);
> --
> 2.39.2
>
>
--
Jan Kara <jack@...e.com>
SUSE Labs, CR
Powered by blists - more mailing lists