linux-kernel - Re: [PATCH V3 3/5] ASoC: codecs: Add code for bin parsing compatible with aw87390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2023 14:06:50 +0100
From:   Mark Brown <broonie@...nel.org>
To:     wangweidong.a@...nic.com
Cc:     lgirdwood@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        perex@...ex.cz, tiwai@...e.com, rf@...nsource.cirrus.com,
        herve.codina@...tlin.com, shumingf@...ltek.com,
        13916275206@....com, ryans.lee@...log.com,
        linus.walleij@...aro.org, ckeepax@...nsource.cirrus.com,
        povik+lin@...ebit.org, arnd@...db.de,
        harshit.m.mogalapalli@...cle.com, u.kleine-koenig@...gutronix.de,
        yang.lee@...ux.alibaba.com, liweilei@...nic.com,
        yijiangtao@...nic.com, trix@...hat.com, colin.i.king@...il.com,
        alsa-devel@...a-project.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3 3/5] ASoC: codecs: Add code for bin parsing compatible
 with aw87390

On Mon, Sep 18, 2023 at 07:52:53PM +0800, wangweidong.a@...nic.com wrote:

> Add aw87390 compatible code to the aw88395_lib.c file
> so that it can parse aw87390's bin file
> Modify function return value
> Remove the fade-enable property because other properties
> already implement thi functionality.
> Modify the transmission method of parameters.

This would be easier to review if it were split up so that the
refactorings are separate commits, removing fade enable is a separate
commit and then finally just the changes to add the new CODEC are done.
That way each individual commit is both smaller and simpler.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)