linux-kernel - Re: [PATCH 1/6] arm64: xilinx: Do not use '

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230918145616.GA16823@pendragon.ideasonboard.com>
Date:   Mon, 18 Sep 2023 17:56:16 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Michal Simek <michal.simek@....com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu,
        michal.simek@...inx.com, git@...inx.com,
        Ashok Reddy Soma <ashok.reddy.soma@...inx.com>,
        Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Manikanta Guntupalli <manikanta.guntupalli@....com>,
        Parth Gajjar <parth.gajjar@....com>,
        Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Tanmay Shah <tanmay.shah@....com>,
        Vishal Sagar <vishal.sagar@....com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/6] arm64: xilinx: Do not use '_' in DT node names

Hi Michal,

Thank you for the patch.

On Mon, Sep 18, 2023 at 02:41:12PM +0200, Michal Simek wrote:
> Character '_' not recommended in node name. Use '-' instead.
> Pretty much run seds below for node names.
> s/zynqmp_ipi/zynqmp-ipi/
> s/nvmem_firmware/nvmem-firmware/
> s/soc_revision/soc-revision/
> s/si5335_/si5335-/
> 
> Signed-off-by: Michal Simek <michal.simek@....com>

The si5335 nodes may be better named after the clock name instead of the
component type, but that's nitpicking.

> ---
> 
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 4 ++--
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi            | 6 +++---
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d0091d3cb764..52f998c22538 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -123,13 +123,13 @@ ina226 {
>  		io-channels = <&u35 0>, <&u35 1>, <&u35 2>, <&u35 3>;
>  	};
>  
> -	si5335_0: si5335_0 { /* clk0_usb - u23 */
> +	si5335_0: si5335-0 { /* clk0_usb - u23 */
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <26000000>;
>  	};
>  
> -	si5335_1: si5335_1 { /* clk1_dp - u23 */
> +	si5335_1: si5335-1 { /* clk1_dp - u23 */
>  		compatible = "fixed-clock";
>  		#clock-cells = <0>;
>  		clock-frequency = <27000000>;
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index b61fc99cd911..e50e95cbe817 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -129,7 +129,7 @@ rproc_1_fw_image: memory@...00000 {
>  		};
>  	};
>  
> -	zynqmp_ipi: zynqmp_ipi {
> +	zynqmp_ipi: zynqmp-ipi {
>  		bootph-all;
>  		compatible = "xlnx,zynqmp-ipi-mailbox";
>  		interrupt-parent = <&gic>;
> @@ -194,12 +194,12 @@ zynqmp_power: zynqmp-power {
>  				mbox-names = "tx", "rx";
>  			};
>  
> -			nvmem_firmware {
> +			nvmem-firmware {
>  				compatible = "xlnx,zynqmp-nvmem-fw";
>  				#address-cells = <1>;
>  				#size-cells = <1>;
>  
> -				soc_revision: soc_revision@0 {
> +				soc_revision: soc-revision@0 {

Unless I'm mistaken, this will change the userspace API, as it changes
the nvmem cell name. Is it an issue ?

>  					reg = <0x0 0x4>;
>  				};
>  			};

-- 
Regards,

Laurent Pinchart