linux-kernel - Re: [PATCH v3 1/5] hwmon: max31827: Make code cleaner

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 18 Sep 2023 07:08:41 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     "Matyas, Daniel" <Daniel.Matyas@...log.com>
Cc:     Jean Delvare <jdelvare@...e.com>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v3 1/5] hwmon: max31827: Make code cleaner

On 9/18/23 02:25, Matyas, Daniel wrote:
> 
> 
>> -----Original Message-----
>> From: Guenter Roeck <groeck7@...il.com> On Behalf Of Guenter Roeck
>> Sent: Saturday, September 16, 2023 2:26 AM
>> To: Matyas, Daniel <Daniel.Matyas@...log.com>
>> Cc: Jean Delvare <jdelvare@...e.com>; Rob Herring
>> <robh+dt@...nel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@...aro.org>; Conor Dooley
>> <conor+dt@...nel.org>; Jonathan Corbet <corbet@....net>; linux-
>> hwmon@...r.kernel.org; devicetree@...r.kernel.org; linux-
>> kernel@...r.kernel.org; linux-doc@...r.kernel.org
>> Subject: Re: [PATCH v3 1/5] hwmon: max31827: Make code cleaner
>>
>> [External]
>>
>> On 9/14/23 00:59, Daniel Matyas wrote:
>>> Now the wait time for one-shot is 140ms, instead of the old 141
>>> (removed the 1ms error).
>>>
>>
>> It was explicitly documented that the wait time was 140 + 1 milli-seconds,
>> presumably to be sure that the conversion is really complete.
>>
>> Why was this an error ? It was _documented_ that way.
>>
>> Guenter
>>
> 
> Well... actually I developed the driver initially and I wrote the documentation, so I know. I decided to remove the error milli-second, because I realized, it isn't really needed. There is no reference about it in the documentation of the chip, and frankly, I didn’t actually encounter any error which would need the 1 milli-second.
> 
> This way, the wait time is more exact and the correspondence with the chip documentation becomes quite straightforward.
> 

This is all fine, but it is yet another example of more than one logical
change in a single patch, and it has nothing to do with the subject. It
is not a cleanup, but a functional change.

Please split _all_ logical changes into separate patches.

Guenter