linux-kernel - Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZQhg+Hcv4QHGJ3+s@smile.fi.intel.com>
Date:   Mon, 18 Sep 2023 17:38:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@...el.com>
To:     Hans de Goede <hdegoede@...hat.com>, Joe Perches <joe@...ches.com>
Cc:     Mark Pearson <mpearson-lenovo@...ebb.ca>, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: think-lmi: Add bulk save feature

On Mon, Sep 18, 2023 at 04:07:53PM +0200, Hans de Goede wrote:
> On 9/18/23 15:57, Andy Shevchenko wrote:
> > On Wed, Sep 06, 2023 at 08:13:14AM -0400, Mark Pearson wrote:

...

> >> +/* There are a limit on the number of WMI operations you can do if you use
> >> + * the default implementation of saving on every set. This is due to a
> >> + * limitation in EFI variable space used.
> >> + * Have a 'bulk save' mode where you can manually trigger the save, and can
> >> + * therefore set unlimited variables - for users that need it.
> >> + */
> > 
> > /*
> >  * This is wrong multi-line comment style. This one
> >  * is used solely in net subsystem.
> >  */
> 
> Good catch, Mark can you fix this one too please ?
> 
> Also I thought that checkpatch.pl used to catch this ?

I don't think it recognizes "net style is only for net related files".

-- 
With Best Regards,
Andy Shevchenko