linux-kernel - Re: [PATCH] memblock: add missing argument definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230918155607.GD3303@kernel.org>
Date:   Mon, 18 Sep 2023 18:56:07 +0300
From:   Mike Rapoport <rppt@...nel.org>
To:     Usama Arif <usama.arif@...edance.com>
Cc:     linux-mm@...ck.org, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org, sfr@...b.auug.org.au,
        muchun.song@...ux.dev, mike.kravetz@...cle.com,
        songmuchun@...edance.com, fam.zheng@...edance.com,
        liangma@...ngbit.com, punit.agrawal@...edance.com
Subject: Re: [PATCH] memblock: add missing argument definition

On Mon, Sep 18, 2023 at 10:06:57AM +0100, Usama Arif wrote:
> Description of argument memblock_type was missing in the commit
> that introduced it.
> 
> Fixes: 70083e1c8ab4 ("memblock: pass memblock_type to memblock_setclr_flag")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Usama Arif <usama.arif@...edance.com>

Reviewed-by: Mike Rapoport (IBM) <rppt@...nel.org>

Andrew, the commit being fixed is in mm-unstable, can you please pick it
up?

> ---
>  mm/memblock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 8f7a0cb668d4..fd492e5bbdbc 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -892,6 +892,7 @@ int __init_memblock memblock_physmem_add(phys_addr_t base, phys_addr_t size)
>  
>  /**
>   * memblock_setclr_flag - set or clear flag for a memory region
> + * @type: memblock type to set/clear flag for
>   * @base: base address of the region
>   * @size: size of the region
>   * @set: set or clear the flag
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.