linux-kernel - Re: [PATCH v3 08/13] KVM: xen: prevent vcpu_id from changing whilst shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <790646bf2b3331aceebf46543a47400cdbfb02bb.camel@infradead.org>
Date:   Mon, 18 Sep 2023 16:59:38 +0100
From:   David Woodhouse <dwmw2@...radead.org>
To:     Paul Durrant <paul@....org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Paul Durrant <pdurrant@...zon.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH v3 08/13] KVM: xen: prevent vcpu_id from changing whilst
 shared_info is valid

On Mon, 2023-09-18 at 14:41 +0000, Paul Durrant wrote:
> From: Paul Durrant <pdurrant@...zon.com>
> 
> To further prepare for automatically using the vcpu_info structures
> embedded in the shared_info page, we need to ensure that the Xen vcpu_id
> cannot change under our feet. We can do this by simply returning -EBUSY
> to any attempt to modify the attribute while the shinfo_cache is active.
> 
> Signed-off-by: Paul Durrant <pdurrant@...zon.com>

Makes sense. Wants explicitly mentioning in the documentation for
KVM_XEN_VCPU_ATTR_TYPE_VCPU_ID. If/when you did that,

Reviewed-by: David Woodhouse <dwmw@...zon.co.uk>


Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)