[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZQm425xPc/8wHXup@google.com>
Date: Tue, 19 Sep 2023 08:06:03 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Hao Peng <flyingpenghao@...il.com>
Cc: pbonzini@...hat.com, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: X86: Use octal for file permission
KVM: x86: (don't capitalize the 'x')
On Tue, Sep 19, 2023, Hao Peng wrote:
> From: Peng Hao <flyingpeng@...cent.com>
>
> Improve code readability and checkpatch warnings:
> WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider
> using octal permissions '0444'.
>
> Signed-off-by: Peng Hao <flyingpeng@...cent.com>
> ---
> arch/x86/kvm/x86.c | 18 +++++++++---------
If we're going to do this, let's do all of x86/kvm in one patch, i.e. clean up
VMX and SVM too.
I generally don't like checkpatch-initiated cleanups, but I vote to go ahead with
this one. I look at the params just often enough that not having to parse the
#defines would add real value for me.
Any objections?
Powered by blists - more mailing lists