[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZQnOTzm6l8RSQquH@memverge.com>
Date: Tue, 19 Sep 2023 12:37:35 -0400
From: Gregory Price <gregory.price@...verge.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: Gregory Price <gourry.memverge@...il.com>,
linux-mm@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arch@...r.kernel.org, linux-api@...r.kernel.org,
linux-cxl@...r.kernel.org, luto@...nel.org, mingo@...hat.com,
bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
arnd@...db.de, akpm@...ux-foundation.org, x86@...nel.org
Subject: Re: [RFC PATCH 3/3] mm/migrate: Create move_phys_pages syscall
On Tue, Sep 19, 2023 at 02:17:15AM +0200, Thomas Gleixner wrote:
> On Thu, Sep 07 2023 at 03:54, Gregory Price wrote:
> > + /* All tasks mapping each page is checked in phys_page_migratable */
> > + nodes_setall(target_nodes);
>
> How is the comment related to nodes_setall() and why is nodes_setall()
> unconditional when target_nodes is only used in the @nodes != NULL case?
>
Short follow up, sorry for the spam. I realized there is a better way
to do this by simply bypassing the task node check in do_pages_moves if
the mm_struct is NULL. This removes the need for this struct
all-together.
Will simplify down for a v2 and add comments to do_pages_move
accordingly.
~Gregory
Powered by blists - more mailing lists