linux-kernel - Re: [PATCH] soc: qcom: rpmh: Include resource name in the trace event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bvzh7acuaaz4twsku4bjj6pzmfjc4sqgcwn7bhy7yksiqllhrs@pvmysisfdgqd>
Date:   Tue, 19 Sep 2023 12:18:53 -0700
From:   Bjorn Andersson <andersson@...nel.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     konrad.dybcio@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: rpmh: Include resource name in the trace event

On Fri, Jul 07, 2023 at 05:57:13PM +0530, Manivannan Sadhasivam wrote:
> The client drivers of RPMh like rpmhpd and bcm-voter has the name of the
> resource they are dealing with along with the address. So let's include
> the resource name in the RPMh trace event as it avoids doing a post
> processing of the trace event to resolve the resource name its address.
> 

Instead of extending the generic client API to pass the strings in (not
all clients are captured in this patch either), can't we do something
like dumping cmd-db into a trace_print_flags array during initialization
and use __print_symbolic() in TP_printk?

Although...for VRMs we probably want sym+<offset> in the output, so
__print_symbolic() isn't a perfect match...

Regards,
Bjorn