linux-kernel - Re: [PATCH v1 1/1] irqdomain: Check virq for 0 before use in irq_dispose

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZQn9uR0o8QHXjN69@smile.fi.intel.com>
Date:   Tue, 19 Sep 2023 22:59:53 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Marc Zyngier <maz@...nel.org>,
        Johan Hovold <johan+linaro@...nel.org>,
        linux-kernel@...r.kernel.org
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] irqdomain: Check virq for 0 before use in
 irq_dispose_mapping()

On Tue, Aug 22, 2023 at 04:51:36PM +0300, Andy Shevchenko wrote:
> It's a bit hard to read the logic since we use virq before checking
> it for 0. Rearrange the code to make it better to understand.
> 
> This, in particular, should clearly answer the question whether caller
> need to perform this check or not, and we have plenty places for both
> variants, confirming a confusion.
> 
> Fun fact that the new code is shorter:
> 
>   Function                                     old     new   delta
>   irq_dispose_mapping                          278     271      -7
>   Total: Before=11625, After=11618, chg -0.06%
> 
> when compiled by GCC on Debian for x86_64.

Any comment on this?

-- 
With Best Regards,
Andy Shevchenko