linux-kernel - Re: [PATCH V3] xfs: use roundup_pow_of_two instead of ffs during xlog_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <874jjqk6t2.fsf@debian-BULLSEYE-live-builder-AMD64>
Date:   Tue, 19 Sep 2023 12:04:44 +0530
From:   Chandan Babu R <chandanbabu@...nel.org>
To:     "Darrick J. Wong" <djwong@...nel.org>
Cc:     Wang Jianchao <jianchwa@...look.com>,
        Chandan Babu R <chandanrlinux@...il.com>,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] xfs: use roundup_pow_of_two instead of ffs during
 xlog_find_tail

On Mon, Sep 18, 2023 at 08:21:38 PM -0700, Darrick J. Wong wrote:
> On Tue, Sep 19, 2023 at 10:06:56AM +0800, Wang Jianchao wrote:
>> Ping ? Do I need other update on this patch ?
>
> Nope, I think this is ok...
>
>> Thanks
>> Jianchao
>> 
>> On 2023/9/13 09:38, Wang Jianchao wrote:
>> > 
>> > In our production environment, we find that mounting a 500M /boot
>> > which is umount cleanly needs ~6s. One cause is that ffs() is
>> > used by xlog_write_log_records() to decide the buffer size. It
>> > can cause a lot of small IO easily when xlog_clear_stale_blocks()
>> > needs to wrap around the end of log area and log head block is
>> > not power of two. Things are similar in xlog_find_verify_cycle().
>> > 
>> > The code is able to handed bigger buffer very well, we can use
>> > roundup_pow_of_two() to replace ffs() directly to avoid small
>> > and sychronous IOs.
>> > 
>> > Reviewed-by: Dave Chinner <dchinner@...hat.com>
>> > Signed-off-by: Wang Jianchao <wangjc136@...ea.com>
>
> ...so let's see if the release manager will take this patch.
>
> Chandan?  Could you pull in the various one-off patches floating around
> on the list that have passed review?  ;)

I had picked this patch along with others sometime last week.

I have pushed the new set of commits to official xfs-linux git repository and
sent the announcement mail around 30 mins ago.

>
> Reviewed-by: Darrick J. Wong <djwong@...nel.org>
>
> PS: If you'd like to send a pull request to push things along, please do
>

-- 
Chandan