linux-kernel - Re: [PATCH] mfd: cs42l43: add REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230919085057.GA103419@ediswmail.ad.cirrus.com>
Date:   Tue, 19 Sep 2023 08:50:57 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Randy Dunlap <rdunlap@...radead.org>
CC:     <linux-kernel@...r.kernel.org>,
        James Schulman <james.schulman@...rus.com>,
        David Rhodes <david.rhodes@...rus.com>,
        "Richard Fitzgerald" <rf@...nsource.cirrus.com>,
        <alsa-devel@...a-project.org>, <patches@...nsource.cirrus.com>,
        Lee Jones <lee@...nel.org>
Subject: Re: [PATCH] mfd: cs42l43: add REGMAP_IRQ requirement

On Mon, Sep 18, 2023 at 12:30:42PM -0700, Randy Dunlap wrote:
> The cs42l43 core uses devm_regmap_add_irq_chip(), so add REGMAP_IRQ
> to what the core driver selects in order to provide this API.
> This fixes a build error:
> 
> aarch64-linux-ld: drivers/mfd/cs42l43.o: in function `cs42l43_boot_work':
> cs42l43.c:(.text+0x19d4): undefined reference to `devm_regmap_add_irq_chip'
> 
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Cc: James Schulman <james.schulman@...rus.com>
> Cc: David Rhodes <david.rhodes@...rus.com>
> Cc: Richard Fitzgerald <rf@...nsource.cirrus.com>
> Cc: alsa-devel@...a-project.org
> Cc: patches@...nsource.cirrus.com
> Cc: Lee Jones <lee@...nel.org>
> ---

Someone already sent a fix for this, that is awaiting review:

https://lore.kernel.org/lkml/tencent_E54C7156F583E15FFE320E576E3389C39A08@qq.com/

But just incase this one gets picked up:

Acked-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles