linux-kernel - Re: [PATCH 4/4] net/onsemi: Add NCN26010 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f79b0d4b9409a223f03c0b36b3544ce1389a500.camel@redhat.com>
Date:   Tue, 19 Sep 2023 11:47:30 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Jay Monkman <jtm@...ingdog.com>, Andrew Lunn <andrew@...n.ch>
Cc:     devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
        Arndt Schuebel <Arndt.Schuebel@...emi.com>,
        Parthiban.Veerasooran@...rochip.com
Subject: Re: [PATCH 4/4] net/onsemi: Add NCN26010 driver

On Mon, 2023-09-18 at 21:54 -0500, Jay Monkman wrote:
> On Mon, Sep 18, 2023 at 06:00:37PM +0200, Andrew Lunn wrote:
> > Is this an OA TC6 device?  At a quick look it does appear to
> > be. Please make use of the framework Microchip is developing:
> > 
> > https://lore.kernel.org/netdev/20230908142919.14849-4-Parthiban.Veerasooran@microchip.com/T/
> 
> Yes it is. I wasn't aware of Microchip's work. Thanks for pointing it out.

I guess this patch is going to change a lot in future revisions...

Please double check the code with checkpatch before the next
submission, there are a few things that could be improved.

Specifically, avoid c++ style comments, and avoid using multiple label
names to jump into the same location - selecting the label name as the
target action will make the code more clear.

Thanks,

Paolo