linux-kernel - 回覆: [PATCH V6 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SEYPR06MB65077401CD3AA45A9D5E5C97F9FAA@SEYPR06MB6507.apcprd06.prod.outlook.com>
Date:   Tue, 19 Sep 2023 10:10:55 +0000
From:   Larry Lai <larry.lai@...jingtech.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     "lee@...nel.org" <lee@...nel.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>, "pavel@....cz" <pavel@....cz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
        "GaryWang@...on.com.tw" <GaryWang@...on.com.tw>,
        Musa Lin <musa.lin@...jingtech.com>,
        Jack Chang <jack.chang@...jingtech.com>,
        Noah Hung <noah.hung@...jingtech.com>
Subject: 回覆: [PATCH V6 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA

Hi Linus, 

       Thank you for spending time to review the V6 patch, for your question, please kindly to check our comments with ">>" beginning.

Best Regards, 
Larry


寄件者: Linus Walleij <linus.walleij@...aro.org>
寄件日期: 2023年9月15日 下午 05:02
收件者: Larry Lai <larry.lai@...jingtech.com>
副本: lee@...nel.org <lee@...nel.org>; andriy.shevchenko@...ux.intel.com <andriy.shevchenko@...ux.intel.com>; pavel@....cz <pavel@....cz>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; linux-gpio@...r.kernel.org <linux-gpio@...r.kernel.org>; linux-leds@...r.kernel.org <linux-leds@...r.kernel.org>; GaryWang@...on.com.tw <GaryWang@...on.com.tw>; Musa Lin <musa.lin@...jingtech.com>; Jack Chang <jack.chang@...jingtech.com>; Noah Hung <noah.hung@...jingtech.com>
主旨: Re: [PATCH V6 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA 
 
On Fri, Sep 15, 2023 at 5:12 AM larry.lai <larry.lai@...jingtech.com> wrote:

> The UP Squared board <http://www.upboard.com> implements certain
> features (pin control) through an on-board FPGA.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Gary Wang <garywang@...on.com.tw>
> Signed-off-by: larry.lai <larry.lai@...jingtech.com>

This v6 overall looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Can the patch be merged on its own?

> +#include "core.h"
> +#include "intel/pinctrl-intel.h"

Didn't notice this before. But if Andy is OK with it, I'm
OK with it, I guess there is a reason? Perhaps it warrants
a comment explaining why you do this?
>>
Need struct intel_pinctrl gpp information to control dedicated Raspberry Pi compatible GPIOs. 
These products (Up boards) are intel approves foundation kits.

Valid reasons:
- You are using Intel-specific HW features also found in this
   FPGA

Invalid reasons:
- Using nifty macros or helpers, then either make them generic
  or (if they are small) duplicate them.

If it was that thing I asked Andy to keep locally because I didn't
agree with its generic usefulness, maybe I should be told to
reconsider.

Yours,
Linus Walleij