linux-kernel - Re: [PATCH] perf jevents: Fix segfault in perf_pmu__find_events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10d67fbc-49b2-25ff-6d02-e13d6a22bced@huawei.com>
Date:   Tue, 19 Sep 2023 09:50:09 +0800
From:   Yang Jihong <yangjihong1@...wei.com>
To:     Namhyung Kim <namhyung@...nel.org>
CC:     <peterz@...radead.org>, <mingo@...hat.com>, <acme@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <irogers@...gle.com>,
        <adrian.hunter@...el.com>, <linux-perf-users@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf jevents: Fix segfault in perf_pmu__find_events_table

Hello,

On 2023/9/19 7:55, Namhyung Kim wrote:
> Hello,
> 
> On Sun, Sep 17, 2023 at 8:05 PM Yang Jihong <yangjihong1@...wei.com> wrote:
>>
>> Before caching the JSON events table, perf_pmu__find_events_table() need
>> to check whether table is empty.
>>
>> For example, AuthenticAMD-15-6B-1 is used. The matching events table cannot
>> be found. As a result, a null pointer is accessed when caching JSON events
>> table, causing segfault.
>>
>> Before:
>>    # perf record -vv true
>>    DEBUGINFOD_URLS=
>>    Using CPUID AuthenticAMD-15-6B-1
>>    Segmentation fault (core dumped)
>>
>> After:
>>    # perf record -vv true
>>    DEBUGINFOD_URLS=
>>    Using CPUID AuthenticAMD-15-6B-1
>>    <SNIP>
>>    [ perf record: Woken up 1 times to write data ]
>>    [ perf record: Captured and wrote 0.005 MB perf.data ]
>>
>> Fixes: 7c52f10c0d4d ("perf pmu: Cache JSON events table")
>> Signed-off-by: Yang Jihong <yangjihong1@...wei.com>
> 
> Thanks for the fix but please see
> 
> https://lore.kernel.org/all/20230913125157.2790375-1-tmricht@linux.ibm.com/
> 

Uh.. no notice that there is already a fix, please ignore it.

Thanks,
Yang