linux-kernel - [PATCH v3 0/2] mfd: axp20x: improve support without interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Sep 2023 11:39:11 +0100
From:   Andre Przywara <andre.przywara@....com>
To:     Lee Jones <lee@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     Icenowy Zheng <uwu@...nowy.me>, Mark Brown <broonie@...nel.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Shengyu Qu <wiagn233@...look.com>,
        Martin Botka <martin.botka1@...il.com>,
        Matthew Croughan <matthew.croughan@....how>,
        linux-sunxi@...ts.linux.dev, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH v3 0/2] mfd: axp20x: improve support without interrupts

This is a more of a re-send, rebased on top of v6.6-rc2, with the tags
added, and adding back the binding patch, since this seems to have fallen
through the cracks somehow.
Changelog below.
------------------------------

Every AXP PMIC we support sports an IRQ pin, that signals certain events
to the SoC. For some of the chip's functionality an interrupt is crucial
for operation (for instance a power key event), but for the basic
regulator features for instance the interrupt does not add much.

Recently we started seeing boards with smaller PMICs, that don't bother
to connect the IRQ line to anything. So far we handled this as a special
case for the AXP305, but there are more examples now that justify a more
general solution.

Patch 1/2 adds more PMICs to the list of chips for which the interrupts
DT property is optional: this is needed to correctly describe some newer
boards without the IRQ pin connected.
Ideally we would make this optional for every PMIC, but it is unclear
whether this is a good idea: many older the "bigger" PMICs have multiple
MFD devices that require an interrupt, so not having interrupt
functionality might not be feasible for their operation. Also so far all
boards with those PMICs connect the IRQ pin, so there is no immediate
need for such a relaxation.

Patch 2/2 then generalises the "no interrupt specified" case in the MFD
driver, as this was special cased for two PMIC models so far. This
allows boards with an AXP313a to not specify an IRQ line: there are
actually multiple boards relying on this out there.

Cheers,
Andre

Changelog v3 ... v2:
- rebased on top of v6.6-rc2
- add back binding patch
- tags added

Changelog v2 ... v1:
- drop reordering approach, use separate cell lists instead

Andre Przywara (2):
  dt-bindings: mfd: x-powers,axp152: make interrupt optional for more
    chips
  mfd: axp20x: Generalise handling without interrupt

 .../bindings/mfd/x-powers,axp152.yaml         |  5 ++-
 drivers/mfd/axp20x.c                          | 44 ++++++++++---------
 2 files changed, 28 insertions(+), 21 deletions(-)

-- 
2.25.1