[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <73a90202-1127-4469-a46d-7986343c51b1@quicinc.com>
Date: Tue, 19 Sep 2023 09:59:54 +0800
From: Tengfei Fan <quic_tengfan@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
<andersson@...nel.org>, <djakov@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-pm@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<quic_tsoni@...cinc.com>, <quic_shashim@...cinc.com>,
<quic_kaushalk@...cinc.com>, <quic_tdas@...cinc.com>,
<quic_tingweiz@...cinc.com>, <quic_aiquny@...cinc.com>,
<kernel@...cinc.com>
Subject: Re: [PATCH v2 2/2] interconnect: qcom: Add SM4450 interconnect
provider driver
在 9/15/2023 8:43 PM, Konrad Dybcio 写道:
> On 15.09.2023 04:01, Tengfei Fan wrote:
>> Add driver for the Qualcomm interconnect buses found in SM4450 based
>> platforms. The topology consists of several NoCs that are controlled
>> by a remote processor that collects the aggregated bandwidth for each
>> master-slave pairs.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@...cinc.com>
>> ---
> [...]
>
>> +static struct qcom_icc_bcm bcm_acv_disp = {
>> + .name = "ACV",
>> + .num_nodes = 1,
>> + .nodes = { &ebi_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_mc0_disp = {
>> + .name = "MC0",
>> + .num_nodes = 1,
>> + .nodes = { &ebi_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_mm0_disp = {
>> + .name = "MM0",
>> + .num_nodes = 1,
>> + .nodes = { &qns_mem_noc_hf_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_sh0_disp = {
>> + .name = "SH0",
>> + .num_nodes = 1,
>> + .nodes = { &qns_llcc_disp },
>> +};
>> +
>> +static struct qcom_icc_bcm bcm_sh1_disp = {
>> + .name = "SH1",
>> + .num_nodes = 1,
>> + .nodes = { &qnm_pcie_disp },
>> +};
> """
> v1 -> v2:
> - remove DISP related paths
> """
>
> you sure?
>
> + I still see _disp nodes..
>
> Konrad
Hi Konrad,
only removed SLAVE_MNOC_HF_MEM_NOC_DISP related code actually as V1 comment.
--
Thx and BRs,
Tengfei Fan
Powered by blists - more mailing lists