linux-kernel - Re: [PATCH 12/15] tty: convert THROTTLE constants into enum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93ccb0ef-8614-4bb2-a8cd-45f425774e30@kernel.org>
Date:   Tue, 19 Sep 2023 12:51:05 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/15] tty: convert THROTTLE constants into enum

On 19. 09. 23, 12:10, Ilpo Järvinen wrote:
> On Tue, 19 Sep 2023, Jiri Slaby (SUSE) wrote:
> 
>> And make an explicit constant for zero too. This allows for easier type
>> checking of the parameter.
>>
>> Note: tty_struct::flow_change is kept as int because include/tty.h
>> (tty_struct) doesn't see tty/tty.h (this enum).
> 
> And it cannot moved there because of what?

It's possible, but would make the constants "public". I hoped for 
forward enum declaration, but since enum is no longer a simple int, the 
compilation then fails with incomplete type of tty_struct.

thanks,
-- 
js
suse labs