linux-kernel - Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7zv7lqkondaacjhmc7oscyqzwugguxvjw2yhdhkv4axhhkts7a@upoxgl3qpunt>
Date:   Tue, 19 Sep 2023 13:00:15 +0200
From:   Michal Koutný <mkoutny@...e.com>
To:     Tejun Heo <tj@...nel.org>
Cc:     Luiz Capitulino <luizcap@...zon.com>, lizefan.x@...edance.com,
        hannes@...xchg.org, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, longman@...hat.com,
        lcapitulino@...il.com
Subject: Re: [PATH v2] cgroup: add cgroup_favordynmods= command-line option

On Mon, Sep 18, 2023 at 07:47:13AM -1000, Tejun Heo <tj@...nel.org> wrote:
> Michal raised some valid concerns. I don't really mind that it's not great
> on the edges tho. Michal, what do you think?

I'd have a few suggestions:
- reset to have_dynmods value instead of false in cgroup_destroy_root()
  (to the benefing of the users of this option, not the common default
  users) or not touch the value in cgroup_destroy_root() at all
- s/CONFIG_FAVOR_DYNMODS/CONFIG_CGROUP_FAVOR_DYNMODS/ in commit message

Those should be minor tweaks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)