linux-kernel - Re: [PATCH v3 13/13] comedi: add HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <75212b6925df202fb75357e2e4f4a59d138b7375.camel@linux.ibm.com>
Date:   Tue, 19 Sep 2023 13:40:53 +0200
From:   Niklas Schnelle <schnelle@...ux.ibm.com>
To:     Ian Abbott <abbotti@....co.uk>, linux-kernel@...r.kernel.org
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Arnd Bergmann <arnd@...nel.org>
Subject: Re: [PATCH v3 13/13] comedi: add HAS_IOPORT dependencies again

On Wed, 2023-09-13 at 18:07 +0100, Ian Abbott wrote:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
> 
> This was previously done in commit b5c75b68b7de ("comedi: add HAS_IOPORT
> dependencies"), but that has been reverted because it made it impossible
> to select configuration options for several comedi drivers.  This is a
> do-over that avoids that.
> 
> Since the original patch, modifications have been made to various comedi
> modules so that they can still be built even if the port I/O functions
> have not been declared, so the configuration options for building those
> modules no longer need to depend on HAS_IOPORT.
> 
> Make the COMEDI_ISA_DRIVERS menu option (which allows configuration
> options for ISA and PC/104 drivers to be selected) depend on HAS_IOPORT,
> and also depend on ISA || ISA_BUS || PC104.
> 
> Co-developed-by: Arnd Bergmann <arnd@...nel.org>
> Signed-off-by: Arnd Bergmann <arnd@...nel.org>
> Co-developed-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> Signed-off-by: Niklas Schnelle <schnelle@...ux.ibm.com>
> Cc: Arnd Bergmann <arnd@...nel.org>
> Cc: Niklas Schnelle <schnelle@...ux.ibm.com>
> Signed-off-by: Ian Abbott <abbotti@....co.uk>
> ---
> v2: N/A.
> v3: N/A.

I just gave this another try with the rest of my series including the
disablement of the I/O port accessors. I tried both allmodconfig and
allyesconfig on s390x and both seem fine. Also definitely see the
comedi driver's without HAS_IOPORT dependeny being built.

Thanks,
Niklas