lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1a57cf3f867d4dfd991ef1d4024c931b@realtek.com>
Date:   Tue, 19 Sep 2023 12:26:31 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "kuba@...nel.org" <kuba@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        nic_swsd <nic_swsd@...ltek.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "bjorn@...k.no" <bjorn@...k.no>,
        "pabeni@...hat.com" <pabeni@...hat.com>
Subject: RE: [PATCH net-next v2 1/2] r8152: remove queuing rx packets in driver

Andrew Lunn <andrew@...n.ch>
> Sent: Tuesday, September 19, 2023 8:08 PM
[...]
> > -     return work_done;
> > +     if (work_done > budget)
> > +             return budget;
> > +     else
> > +             return work_done;
> >  }
> 
> I don't know NAPI too well. Are there implications of not telling it
> the truth?

You could check the reply from Jakub Kicinski, as following link.
https://www.spinics.net/lists/netdev/msg933846.html
https://www.spinics.net/lists/netdev/msg933923.html

If the work_done is more than budget, I should return budget.

Best Regards,
Hayes

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ