linux-kernel - Re: [patch V3 04/30] x86/microcode/intel: Simplify scan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230919125203.GBZQmZc5C9m24/vEop@fat_crate.local>
Date:   Tue, 19 Sep 2023 14:52:03 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>, x86@...nel.org,
        "Chang S. Bae" <chang.seok.bae@...el.com>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Nikolay Borisov <nik.borisov@...e.com>
Subject: Re: [patch V3 04/30] x86/microcode/intel: Simplify scan_microcode()

On Tue, Sep 12, 2023 at 09:57:49AM +0200, Thomas Gleixner wrote:
> Make it readable and comprehensible.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> ---
>  arch/x86/kernel/cpu/microcode/intel.c |   30 ++++++++----------------------
>  1 file changed, 8 insertions(+), 22 deletions(-)
> 
> --- a/arch/x86/kernel/cpu/microcode/intel.c
> +++ b/arch/x86/kernel/cpu/microcode/intel.c
> @@ -265,25 +265,19 @@ static void save_microcode_patch(void *d
>  		return;
>  
>  	/* Save for early loading */
> -	intel_ucode_patch = (struct microcode_intel *)p;
> +		intel_ucode_patch = (struct microcode_intel *)p;

This got committed by mistake.

> -/*
> - * Get microcode matching with BSP's model. Only CPUs with the same model as
> - * BSP can stay in the platform.
> - */
> -static struct microcode_intel *
> -scan_microcode(void *data, size_t size, struct ucode_cpu_info *uci, bool save)
> +/* Scan CPIO for microcode matching the boot CPUs family, model, stepping */

"... the boot CPU's... " or simply the "BSP's".

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette