linux-kernel - Re: [PATCH v6 13/33] dt-bindings: usb: dwc3: Add snps,num-hc-interrupters definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f77aa92d-b71c-b6f7-bce2-35fa0c3011c0@quicinc.com>
Date:   Mon, 18 Sep 2023 17:23:16 -0700
From:   Wesley Cheng <quic_wcheng@...cinc.com>
To:     Rob Herring <robh@...nel.org>
CC:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        <mathias.nyman@...el.com>, <gregkh@...uxfoundation.org>,
        <lgirdwood@...il.com>, <broonie@...nel.org>, <perex@...ex.cz>,
        <tiwai@...e.com>, <agross@...nel.org>, <andersson@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <srinivas.kandagatla@...aro.org>, <bgoswami@...cinc.com>,
        <Thinh.Nguyen@...opsys.com>, <linux-kernel@...r.kernel.org>,
        <linux-usb@...r.kernel.org>, <alsa-devel@...a-project.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 13/33] dt-bindings: usb: dwc3: Add
 snps,num-hc-interrupters definition

Hi Rob,

On 9/18/2023 1:19 PM, Rob Herring wrote:
> On Fri, Sep 15, 2023 at 05:43:45PM -0700, Wesley Cheng wrote:
>> Hi Konrad,
>>
>> On 9/15/2023 5:35 PM, Konrad Dybcio wrote:
>>> On 16.09.2023 02:10, Wesley Cheng wrote:
>>>> Add a new definition for specifying how many XHCI secondary interrupters
>>>> can be allocated.  XHCI in general can potentially support up to 1024
>>>> interrupters, which some uses may want to limit depending on how many
>>>> users utilize the interrupters.
>>>>
>>>> Signed-off-by: Wesley Cheng <quic_wcheng@...cinc.com>
>>>> ---
>>> Any reason for a DWC3-specific property? Why not just
>>> use the XHCI-common one from patch 14 and error out if
>>> a value of more than 8 is found?
>>>
> 
> I'm pretty sure I said use the common one already...
> 

Yes, you mentioned that in the last rev.

>>
>> Not every XHCI plat user is going to be DWC3.  In case DWC3 is used, the
>> DWC3 host driver is the one that populates and adds the XHCI plat device (no
>> separate device node for XHCI), so that requires the DWC3 host to also
>> populate properties for the XHCI device. (dwc3_host_init())
> 
> This binding references usb-xhci.yaml already, so any property from
> there is allowed. Linux needs to handle that regardless of what the
> driver structure/division looks like.
> 

Ok, understood.  I will remove the need to have another DWC3 property 
and just use the XHCI one directly.  Checks are already in place in the 
DWC3 parser to limit the interrupters if it exceeds 8.

Thanks
Wesley Cheng