linux-kernel - Re: [PATCH for-v6.6] mfd: cs42l43: Use correct macro for new-style PM runtime ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230919135835.GT13143@google.com>
Date:   Tue, 19 Sep 2023 14:58:35 +0100
From:   Lee Jones <lee@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        patches@...nsource.cirrus.com, linux-kernel@...r.kernel.org,
        kernel@...gutronix.de,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH for-v6.6] mfd: cs42l43: Use correct macro for new-style
 PM runtime ops

On Tue, 19 Sep 2023, Uwe Kleine-König wrote:

> From: Charles Keepax <ckeepax@...nsource.cirrus.com>
> 
> The code was accidentally mixing new and old style macros, update the
> macros used to remove an unused function warning whilst building with
> no PM enabled in the config.
> 
> Fixes: ace6d1448138 ("mfd: cs42l43: Add support for cs42l43 core driver")
> Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> Link: https://lore.kernel.org/all/20230822114914.340359-1-ckeepax@opensource.cirrus.com/
> Reviewed-by: Nathan Chancellor <nathan@...nel.org>
> Tested-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Acked-by: Lee Jones <lee@...nel.org>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
> Hello Linus,
> 
> this patch was submitted on August 22 already, but -rc2 is still
> unfixed. This makes allmodconfig builds on (at least) s390 and m68k
> fail.
> 
> Lee who should normally send this fix to you seems to be swamped in
> other work and asked: "If anyone wants to submit this directly to Linus
> before -rc1, please, be my guest."
> 
> Voilà, I'm Lee's guest now :-)

Thanks Uwe.

> Thanks for considering to take this patch this way,
> Uwe
> 
>  drivers/mfd/cs42l43.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mfd/cs42l43.c b/drivers/mfd/cs42l43.c
> index 37b23e9bae82..7b6d07cbe6fc 100644
> --- a/drivers/mfd/cs42l43.c
> +++ b/drivers/mfd/cs42l43.c
> @@ -1178,8 +1178,8 @@ static int cs42l43_runtime_resume(struct device *dev)
>  }
>  
>  EXPORT_NS_GPL_DEV_PM_OPS(cs42l43_pm_ops, MFD_CS42L43) = {
> -	SET_SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> -	SET_RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
> +	SYSTEM_SLEEP_PM_OPS(cs42l43_suspend, cs42l43_resume)
> +	RUNTIME_PM_OPS(cs42l43_runtime_suspend, cs42l43_runtime_resume, NULL)
>  };
>  
>  MODULE_DESCRIPTION("CS42L43 Core Driver");
> 
> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
> -- 
> 2.40.1
> 

-- 
Lee Jones [李琼斯]