[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <77267d52-e423-4de7-b840-9945699884b3@xs4all.nl>
Date: Tue, 19 Sep 2023 16:05:40 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Benjamin Gaignard <benjamin.gaignard@...labora.com>,
mchehab@...nel.org, tfiga@...omium.org, m.szyprowski@...sung.com,
ming.qian@....com, ezequiel@...guardiasur.com.ar,
p.zabel@...gutronix.de, gregkh@...uxfoundation.org,
nicolas.dufresne@...labora.com
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
kernel@...labora.com
Subject: Re: [PATCH v7 32/49] media: renesas: Stop direct calls to queue
num_buffers field
On 14/09/2023 15:33, Benjamin Gaignard wrote:
> Use vb2_get_num_buffers() to avoid using queue num_buffer field directly.
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>
> ---
> drivers/media/platform/renesas/rcar_drif.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar_drif.c b/drivers/media/platform/renesas/rcar_drif.c
> index 163a4ba61c17..020845689ed3 100644
> --- a/drivers/media/platform/renesas/rcar_drif.c
> +++ b/drivers/media/platform/renesas/rcar_drif.c
> @@ -424,10 +424,11 @@ static int rcar_drif_queue_setup(struct vb2_queue *vq,
> unsigned int sizes[], struct device *alloc_devs[])
> {
> struct rcar_drif_sdr *sdr = vb2_get_drv_priv(vq);
> + unsigned int q_num_buffers = vb2_get_num_buffers(vq);
>
> /* Need at least 16 buffers */
> - if (vq->num_buffers + *num_buffers < 16)
> - *num_buffers = 16 - vq->num_buffers;
> + if (q_num_buffers + *num_buffers < 16)
> + *num_buffers = 16 - q_num_buffers;
This should be dropped, and instead min_buffers_needed should be set to 16.
Regards,
Hans
>
> *num_planes = 1;
> sizes[0] = PAGE_ALIGN(sdr->fmt->buffersize);
Powered by blists - more mailing lists