linux-kernel - Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230920165659.coe7d2lydiaatoby@quack3>
Date:   Wed, 20 Sep 2023 18:56:59 +0200
From:   Jan Kara <jack@...e.cz>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Peter Lafreniere <peter@...jl.ca>, segher@...nel.crashing.org,
        anton.ivanov@...bridgegreys.com, ink@...assic.park.msu.ru,
        jack@...e.cz, johannes@...solutions.net,
        linux-alpha@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-m68k@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-sh@...r.kernel.org,
        linux-um@...ts.infradead.org, linux@...linux.org.uk,
        linuxppc-dev@...ts.ozlabs.org, reiserfs-devel@...r.kernel.org,
        richard.henderson@...aro.org, richard@....at,
        tsbogend@...ha.franken.de
Subject: Re: [PATCH 0/7] arch/*: config: Remove ReiserFS from defconfig

On Tue 19-09-23 18:02:39, Geert Uytterhoeven wrote:
> Hi Peter,
> 
> On Tue, Sep 19, 2023 at 5:58 PM Peter Lafreniere <peter@...jl.ca> wrote:
> >  2) Stops building an obsolete and largely-unused filesystem unnecessarily.
> >     Some hobbyist targets like m68k and alpha may prefer to keep all filesystems
> >     available until total removal, but others like arm and UML have no need for
> >     ReiserFS to be built unless specifically configured.
> 
> As UML is used a lot for testing, isn't it actually counter-productive
> to remove ReiserFS from the UML defconfig?  The less testing it
> receives, the higher the chance of introducing regressions.

The only testing I know about for reiserfs (besides build testing) is
syzbot. And regarding the people / bots doing filesystem testing I know
none of them uses UML. Rather it is x86 VMs these days where reiserfs is
disabled in the defconfig for a *long* time (many years). Also when you do
filesystem testing, you usually just test the few filesystems you care
about and for which you have all the tools installed. So frankly I don't
see a good reason to leave reiserfs enabled in defconfigs. But sure if
m68k or other arch wants to keep reiserfs in it's defconfig for some
consistency reasons, I'm fine with it. I just suspect that for most archs
this is just a historical reason.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR