linux-kernel - Re: [PATCH linux-next] thermal: int340x: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51b3a2f115b2392557331442460c2a52432f399d.camel@linux.intel.com>
Date:   Wed, 20 Sep 2023 12:29:31 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>
Cc:     daniel.lezcano@...aro.org, rui.zhang@...el.com,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] thermal: int340x: processor_thermal: Ack all
 PCI interrupts

On Wed, 2023-09-20 at 21:21 +0200, Rafael J. Wysocki wrote:
> On Wed, Sep 20, 2023 at 8:52 PM Srinivas Pandruvada
> <srinivas.pandruvada@...ux.intel.com> wrote:
> > 
> > All interrupts from the processor thermal PCI device requires ACK.
> > This
> > is done by writing 0x01 at offset 0xDC in the config space. This is
> > already done for the thereshold interrupt. Extend this for the
> > workload
> > hint interrupt.
> > 
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@...ux.intel.com>
> 
> Is this a fix for one of the commits in linux-next?  If so, which
> one?
This is on top of workload hints patches.  I marked linux-next as they
are not in mainline kernel.

This can alternatively merged to 
e682b86211a1 thermal: int340x: Handle workload hint interrupts

But not sure how to mark the commit id as they will change.
Whatever you prefer.

Thanks,
Srinivas



> 
> > ---
> >  .../intel/int340x_thermal/processor_thermal_device_pci.c       | 3
> > ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pc
> > i.c
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pc
> > i.c
> > index 44b179ce9bc9..3c5ced79ead0 100644
> > ---
> > a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pc
> > i.c
> > +++
> > b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pc
> > i.c
> > @@ -154,10 +154,11 @@ static irqreturn_t
> > proc_thermal_irq_handler(int irq, void *devid)
> >         if (status) {
> >                 /* Disable enable interrupt flag */
> >                 proc_thermal_mmio_write(pci_info,
> > PROC_THERMAL_MMIO_INT_ENABLE_0, 0);
> > -               pci_write_config_byte(pci_info->pdev, 0xdc, 0x01);
> >                 pkg_thermal_schedule_work(&pci_info->work);
> >         }
> > 
> > +       pci_write_config_byte(pci_info->pdev, 0xdc, 0x01);
> > +
> >         return ret;
> >  }
> > 
> > --
> > 2.40.1
> >