linux-kernel - Re: [PATCH 4/4] iio: resolver: add new driver for AD2S1210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202309210740.YRdN185w-lkp@intel.com>
Date:   Thu, 21 Sep 2023 07:35:03 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Lechner <dlechner@...libre.com>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-staging@...ts.linux.dev
Cc:     oe-kbuild-all@...ts.linux.dev,
        David Lechner <dlechner@...libre.com>,
        linux-kernel@...r.kernel.org, Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Axel Haslam <ahaslam@...libre.com>,
        Philip Molloy <pmolloy@...libre.com>
Subject: Re: [PATCH 4/4] iio: resolver: add new driver for AD2S1210

Hi David,

kernel test robot noticed the following build warnings:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v6.6-rc2 next-20230920]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/David-Lechner/dt-bindings-iio-resolver-add-devicetree-bindings-for-ad2s1210/20230921-010529
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
patch link:    https://lore.kernel.org/r/20230920170253.203395-5-dlechner%40baylibre.com
patch subject: [PATCH 4/4] iio: resolver: add new driver for AD2S1210
config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230921/202309210740.YRdN185w-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20230921/202309210740.YRdN185w-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202309210740.YRdN185w-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/iio/resolver/ad2s1210.c:113: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Writes the given data to the given register address.
   drivers/iio/resolver/ad2s1210.c:151: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Reads value from one of the registers.
   drivers/iio/resolver/ad2s1210.c:201: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Sets the excitation frequency and performs software reset.


vim +113 drivers/iio/resolver/ad2s1210.c

   111	
   112	/**
 > 113	 * Writes the given data to the given register address.
   114	 *
   115	 * If the mode is configurable, the device will first be placed in
   116	 * configuration mode.
   117	 */
   118	static int ad2s1210_regmap_reg_write(void *context, unsigned int reg,
   119					     unsigned int val)
   120	{
   121		struct ad2s1210_state *st = context;
   122		struct spi_transfer xfers[] = {
   123			{
   124				.len = 1,
   125				.rx_buf = &st->rx[0],
   126				.tx_buf = &st->tx[0],
   127				.cs_change = 1,
   128			}, {
   129				.len = 1,
   130				.rx_buf = &st->rx[1],
   131				.tx_buf = &st->tx[1],
   132			},
   133		};
   134		int ret;
   135	
   136		/* values can only be 7 bits, the MSB indicates an address */
   137		if (val & ~0x7F)
   138			return -EINVAL;
   139	
   140		st->tx[0] = reg;
   141		st->tx[1] = val;
   142	
   143		ret = ad2s1210_set_mode(st, AD2S1210_MODE_CONFIG);
   144		if (ret < 0)
   145			return ret;
   146	
   147		return spi_sync_transfer(st->sdev, xfers, ARRAY_SIZE(xfers));
   148	}
   149	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki