linux-kernel - Re: [PATCH v1] LoongArch: Remove dead code in relocate_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H74iDp3Sv8CaJAoS1yEUYsQFkNRVABSNYz23zXAqnCrfw@mail.gmail.com>
Date:   Wed, 20 Sep 2023 14:28:08 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Jinyang He <hejinyang@...ngson.cn>
Cc:     Tiezhu Yang <yangtiezhu@...ngson.cn>, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] LoongArch: Remove dead code in relocate_new_kernel

Queued for loongarch-next, thanks.

Huacai

On Tue, Sep 19, 2023 at 5:24 PM Jinyang He <hejinyang@...ngson.cn> wrote:
>
> Not need my tag. Youling found that before, and simply talked about it
> to me.
>
> Thanks.
>
>
> On 2023-09-19 17:07, Tiezhu Yang wrote:
> > The initial aim is to silence the following objtool warning:
> >
> > arch/loongarch/kernel/relocate_kernel.o: warning: objtool: relocate_new_kernel+0x74: unreachable instruction
> >
> > There are two adjacent "b" instructions, the second one is unreachable,
> > it is dead code, just remove it.
> >
> > Co-developed-by: Jinyang He <hejinyang@...ngson.cn>
> > Signed-off-by: Jinyang He <hejinyang@...ngson.cn>
> > Co-developed-by: Youling Tang <tangyouling@...ngson.cn>
> > Signed-off-by: Youling Tang <tangyouling@...ngson.cn>
> > Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> > ---
> >   arch/loongarch/kernel/relocate_kernel.S | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/loongarch/kernel/relocate_kernel.S b/arch/loongarch/kernel/relocate_kernel.S
> > index d132525..f49f6b0 100644
> > --- a/arch/loongarch/kernel/relocate_kernel.S
> > +++ b/arch/loongarch/kernel/relocate_kernel.S
> > @@ -72,7 +72,6 @@ copy_word:
> >       LONG_ADDI       s5, s5, -1
> >       beqz            s5, process_entry
> >       b               copy_word
> > -     b               process_entry
> >
> >   done:
> >       ibar            0
>
>